feat(cdp): activity logs #25253
feat(cdp): activity logs #25253
Conversation
|
Size Change: +216 B (+0.02%) Total Size: 1.14 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
This is sick, nice work. Should we add something to the docs calling out the diff viewer in function history? It's effectively function versioning, which I think is a big deal for hog usability, but it's a little hidden right now (you can't view it while editing a function, for example).
|
Technically you can view it if you open it in a new tab 🙃... That said, yeah, now that we are collecting the data, we can start to show it in other places as well. We could even put a little hourglass next to each input field, and show its individual changes in a popover. Docs could get an upgrade too. One place where I'd really like to add the diff viewer is upgrades --> what'll change if I upgrade my template to the new version. The old apps/plugins actually had something similar (link to a github diff if a new version is available). But let's get this chunk of work in first 😅 |
Problem
We want to track activity logs for hog functions (destinations).
Turns out activity logs are in the middle of a migration. We have one
ActivityLogmodel that collects all the data, yet until now most logs were accessed via urls like.../feature_flags/1/activity. Since I'd like to show both "app/plugin" and "hog function" logs in the same list, I needed to use the common endpoint.Changes
How did you test this code?
Backend tests. Made sure the pagination worked. Clicked around in the interface.